Add reporting of rocks for enhanced weathering and plots to cs2 #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LaviniaBaumstark I do not understand why the check is failing, could you help me out please? |
|
@fbenke-pik or @LaviniaBaumstark, would one of you have time to briefly review this PR, or could you recommend someone else to do it? Many thanks! |
|
Looks good to me. Just resolve the conflicts with buildLibrary, then I will approve |
|
Many thanks @fbenke-pik ! |
fbenke-pik
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds reporting of rock variables for enhanced weathering:
a) the amount of rocks spread in each time step: v33_EW_onfield
b) the amount of rocks weathering on the field (accumulating over time): v33_EW_onfield_tot
For each, the total and amounts by climate grade (warm and temperate regions) are included.
It further adds 2 lineplots to cs2, showing only the total of spreading and of weathering on the fields.
The plots are added to the CDR emissions section (chapter 2) where otherwise only GHG emissions are shown.
There are no other CDR-specific reportings, thus it does not yet justify the addition of another chapter.
It is currently not backwards compatible with REMIND versions prior to the CDR module refactoring.