Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.0 #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

2.1.0 #81

wants to merge 1 commit into from

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Feb 10, 2025

What's Changed

New Contributors

Full Changelog: v2.0.0...v2.1.0

@Phillip9587
Copy link
Contributor

@wesleytodd What about #59? The other packages updated the engines field in the minor version should we include it?

@wesleytodd
Copy link
Member Author

I know they did, and I think we reached a consensus that they shouldn't have. expressjs/discussions#286 (comment)

Let me know if you read that differently.

@Phillip9587
Copy link
Contributor

But you just included a engines field update in the router release so i think it would make sense to include it in this minor too:

@Phillip9587
Copy link
Contributor

I'm good with either approach—just happy to see this release go out and clean up some legacy code along the way!

@wesleytodd
Copy link
Member Author

But you just included a engines field update in the router release

Ah, I didn't catch that as I was reading through that release PR. Too much trust in the approvals and too much time since I last looked at the content. My bad.

The agreement was for sure those shouldn't have landed, but now that I published the only fix would be a fast follow patch to remove it again. @ctcpip thoughts on that? Should we back that out in a fast patch?

Either way I don't think repeating the mistake here is a good idea. I would rather back out that PR that landed than release this also with the breaking engines field change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants