Skip to content

Advanced Many-to-Many (Object) Relations: Support opening assigned element via double-click #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BlackbitDevs
Copy link
Contributor

@BlackbitDevs BlackbitDevs commented Mar 11, 2025

In editing panel, for non-advanced many-to-many (object) relations it is possible since a long time to open the referenced element via double click. For advanced many-to-many (object) relations this does currently not work. This PR adds this feature: When you double-click a column which is no meta column for the relation, the assigned element gets opened.

Steps to reproduce:

  1. Create data object class with an advanced many-to-many object relation, set allowed class to the class itself, add a meta / custom field meta
  2. Create object of this class
  3. Create another object of this class
  4. Open object from 3. and assign the object from 2. to the relation
  5. Double-click a cell on the relation table except the meta column meta

With PR: Object from 2. will open.
Without PR: Nothing happens.

Have used target branch 1.7 because imho it is a UX bug. If you disagree and favor to put it into 2.x, also fine for me.

@BlackbitDevs BlackbitDevs changed the base branch from 2.x to 1.7 March 11, 2025 09:17
@BlackbitDevs BlackbitDevs force-pushed the advanced-m2m-object-relation-doubleclick-to-open branch from 243f328 to d0fc112 Compare March 11, 2025 09:19
Copy link

@BlackbitDevs BlackbitDevs changed the title Advanced Many-to-Many (object) Relations: Support opening assigned element via double-click Advanced Many-to-Many (Object) Relations: Support opening assigned element via double-click Mar 11, 2025
@ghost ghost added the Pimcore:ToDo label Mar 12, 2025
@mcop1 mcop1 self-assigned this May 22, 2025
@mcop1
Copy link
Contributor

mcop1 commented May 22, 2025

@BlackbitDevs could you please rebase it to the 2.0 bugfix branch? Thank you!

@mcop1 mcop1 changed the base branch from 1.7 to 2.0 May 22, 2025 10:46
@mcop1
Copy link
Contributor

mcop1 commented May 22, 2025

@BlackbitDevs could you please rebase it to the 2.0 bugfix branch? Thank you!

Never mind, thanks for the pr :)

@mcop1 mcop1 merged commit 5f5ab3c into pimcore:2.0 May 22, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
@mcop1 mcop1 added this to the 2.0.1 milestone May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants