Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concept of IsValidDataObjectTriggerEvent. #944

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

Add concept of IsValidDataObjectTriggerEvent. #944

wants to merge 2 commits into from

Conversation

laticrete-pimcore
Copy link

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fashxp
fashxp requested changes Mar 5, 2025
View reviewed changes
src/Event/IsValidDataObjectTriggerEvent.php

protected ElementEventInterface $event;

public function getEvent(): ElementEventInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we name that something like sourceEvent?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about triggerEvent for consistency with the name of the class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cancan101 cancan101 cancan101 left review comments

@fashxp fashxp fashxp requested changes

Assignees
No one assigned
Labels
Improvement Pimcore:Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laticrete-pimcore @cancan101 @fashxp @wisconaut