-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting Date and DateTime-fields to empty / null even if the fieldtype is DATETIME #950
Conversation
…eldtype is DATETIME
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
recheck |
/recheck |
thx for your contribution. |
Thanks for your reply. Yes, it does. I also retried the commit with the Primary Address in github, but it didn't work. |
when you open https://github.com/pimcore/data-hub/pull/950.patch, you see the e-mail address of the commit. I'm not aware of any general issues with the CLA. Most of the time the e-mail address mismatch is the reason for failing... |
another thing you could try - if not done already - is to create the directly in the web-ui of github. |
ok, thanks. The mailaddress in the commit is correct. I'll try the web-ui. |
@ferdinand-it I think you only need to create a pull request comment here with following content:
|
I have read the CLA Document and I hereby sign the CLA |
Ah damn, I missed the obvious 😜 |
Great, looks like this worked. |
thx yery much |
Currently, Date or DateTime fields to which zero or an empty string is passed behave differently depending on whether BIGINT or DATETIME is specified as the FieldType. For the latter, it is not possible to set the date empty via graphql. Instead, the date is set to “1970-01-01 01:00:00” in this case.
To solve this issue, it is now checked if the value pasased via graphql is an empty string or null.