Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Date and DateTime-fields to empty / null even if the fieldtype is DATETIME #950

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

ferdinand-it
Copy link

Currently, Date or DateTime fields to which zero or an empty string is passed behave differently depending on whether BIGINT or DATETIME is specified as the FieldType. For the latter, it is not possible to set the date empty via graphql. Instead, the date is set to “1970-01-01 01:00:00” in this case.

grafik

To solve this issue, it is now checked if the value pasased via graphql is an empty string or null.

Copy link

github-actions bot commented Mar 4, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

sonarqubecloud bot commented Mar 4, 2025

@ferdinand-it
Copy link
Author

@brusch @fashxp do you have any idea what I'm doing wrong with the CLA check?
I signed the CLA and used my primary github mail address for the commit. But the check still fails...
grafik

@ferdinand-it
Copy link
Author

recheck

@ferdinand-it
Copy link
Author

/recheck

@fashxp
Copy link
Member

fashxp commented Mar 5, 2025

thx for your contribution.
concerning CLA check ... does on of the e-mail addresses configured in your github account match the e-mail address in the commit of that PR?

@ferdinand-it
Copy link
Author

thx for your contribution. concerning CLA check ... does on of the e-mail addresses configured in your github account match the e-mail address in the commit of that PR?

Thanks for your reply. Yes, it does. I also retried the commit with the Primary Address in github, but it didn't work.
Now I unchecked the "Keep my email addresses private"-box. I could try to create a new commit/PR with this setting. If this won't work, I have now more ideas... But there are no general issues with the CLA-check and I'm the only one with such problems?

@fashxp
Copy link
Member

fashxp commented Mar 5, 2025

when you open https://github.com/pimcore/data-hub/pull/950.patch, you see the e-mail address of the commit.

I'm not aware of any general issues with the CLA. Most of the time the e-mail address mismatch is the reason for failing...

@fashxp
Copy link
Member

fashxp commented Mar 5, 2025

another thing you could try - if not done already - is to create the directly in the web-ui of github.

@ferdinand-it
Copy link
Author

ok, thanks. The mailaddress in the commit is correct. I'll try the web-ui.

@blankse
Copy link
Contributor

blankse commented Mar 5, 2025

@ferdinand-it I think you only need to create a pull request comment here with following content:

I have read the CLA Document and I hereby sign the CLA

@ferdinand-it
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@fashxp
Copy link
Member

fashxp commented Mar 5, 2025

Ah damn, I missed the obvious 😜
Thx @blankse

@ferdinand-it
Copy link
Author

@ferdinand-it I think you only need to create a pull request comment here with following content:

I have read the CLA Document and I hereby sign the CLA

Great, looks like this worked.

@fashxp fashxp added the Bug label Mar 5, 2025
@fashxp fashxp added this to the 1.9.3 milestone Mar 5, 2025
@fashxp
Copy link
Member

fashxp commented Mar 5, 2025

thx yery much

@fashxp fashxp merged commit 16b1a6e into pimcore:1.9 Mar 5, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants