Remove chains import for getBlock query
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import of the `chains` variable from `fetch/openapi.ts` caused a DB query to be executed once the module was loaded. This behavior was also preventing testing any function inside the `queries.ts` module. The fix makes the `getBlock` function explicitly query the DB for supported chains (as they might also get updated over time). The function is mocked in the tests using the latest Bun feature (1.0.8+) of *mock modules* in order to allow "offline" testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import of the
chainsvariable fromfetch/openapi.tscaused a DB query to be executed once the module was loaded. This behavior was also preventing testing any function inside thequeries.tsmodule.The fix makes the
getBlockfunction explicitly query the DB for supported chains (as they might also get updated over time). The function is mocked in the tests using the latest Bun feature (1.0.8+) of mock modules in order to allow "offline" testing.