Warn when no definition is found for a specified primary key

pinchbv · Oct 30, 2023 · 230cbcf · 230cbcf
1 parent 9967c32
commit 230cbcf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/floor_generator/lib/processor/entity_processor.dart b/floor_generator/lib/processor/entity_processor.dart
@@ -221,7 +221,8 @@ class EntityProcessor extends QueryableProcessor<Entity> {
         .getAnnotation(annotations.Entity)
         ?.getField(AnnotationField.entityPrimaryKeys)
         ?.toListValue()
-        ?.map((object) => object.toStringValue());
+        ?.map((object) => object.toStringValue())
+        .toSet();
 
     if (compoundPrimaryKeyColumnNames == null ||
         compoundPrimaryKeyColumnNames.isEmpty) {
@@ -237,6 +238,11 @@ class EntityProcessor extends QueryableProcessor<Entity> {
       throw _processorError.missingPrimaryKey;
     }
 
+    if (compoundPrimaryKeyFields.length !=
+        compoundPrimaryKeyColumnNames.length) {
+      throw _processorError.primaryKeyNotFound;
+    }
+
     return PrimaryKey(compoundPrimaryKeyFields, false);
   }
 

diff --git a/floor_generator/lib/processor/error/entity_processor_error.dart b/floor_generator/lib/processor/error/entity_processor_error.dart
@@ -18,6 +18,14 @@ class EntityProcessorError {
     );
   }
 
+  InvalidGenerationSourceError get primaryKeyNotFound {
+    return InvalidGenerationSourceError(
+      'Primary key not found for ${_classElement.displayName}.',
+      todo: 'Make sure that all the primary keys you defined exist as columns.',
+      element: _classElement,
+    );
+  }
+
   InvalidGenerationSourceError get missingParentColumns {
     return InvalidGenerationSourceError(
       'No parent columns defined for foreign key.',