-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All test in floor_generator run now #808
All test in floor_generator run now #808
Conversation
…tring_extension.dart that came after the update. Also fixed some test in entity_processor_test.dart
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/dep_update #808 +/- ##
=====================================================
Coverage ? 91.92%
=====================================================
Files ? 11
Lines ? 223
Branches ? 0
=====================================================
Hits ? 205
Misses ? 18
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work
left a few comments to find out what benefits these changes bring
floor_generator/test/misc/extension/type_converter_element_extension_test.dart
Show resolved
Hide resolved
…o test_utils and expect the test to throw this exception
floor_generator/test/misc/extension/type_converter_element_extension_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you for contributing 🚀
# Conflicts: # .github/workflows/ci.yml # floor/pubspec.lock # floor/pubspec.yaml # floor_generator/pubspec.lock # floor_generator/pubspec.yaml
The command flutter test did not work. To fix this, I updated all the dependencies. After doing this, some problems arose in the fakes.dart and string_extension.dart files, which I also fixed. Additionally, I corrected some tests that were not accurate. To run the tests, you need to use flutter pub run test.