Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shell scripts to have more reuse #830

Merged
merged 13 commits into from
May 27, 2024
Merged

Update shell scripts to have more reuse #830

merged 13 commits into from
May 27, 2024

Conversation

stephanmantel
Copy link
Contributor

No description provided.

@stephanmantel
Use a loop to execute commands on every folder
f618516 
In stead of having to repeat the command for every folder,
we can iterate over a list of them and execute the same
command over and over again.

This also fixes the SC2164 warning that was present.
@stephanmantel
Introduce a script that iterates over every folder
bc91c54
@stephanmantel
Reformat file
12420b5
@stephanmantel
Add example usage to top comment
9f7457e
@stephanmantel
Exit with a clear message when no input argument
a1e4318
@stephanmantel
Run analyse using foreach_module script
788502e
@stephanmantel
Make script executable before executing
8f081e2 
In case it was not yet executable.
It makes it only executable on user level
@stephanmantel
Add comment
1b91eb8
@stephanmantel
Run formatter using foreach_module script too
4106dd2
@stephanmantel
Run pub get in loop too
68eab3d
@stephanmantel
Add generate tool script
463aa12 
Running the build_runner on every module.
This replaces the existing individual generation scripts.
Those modules without anything to generate will just output
"Could not find package `build_runner` or file `build_runner`"
and continue to the next, which is fine.
dkaera
dkaera approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@dkaera dkaera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanmantel stephanmantel merged commit aab7264 into develop May 27, 2024
2 of 6 checks passed
@stephanmantel stephanmantel deleted the tools_scripts branch May 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkaera dkaera dkaera approved these changes

@SEGVeenstra SEGVeenstra SEGVeenstra approved these changes

@vitusortner vitusortner Awaiting requested review from vitusortner

@hendrikvdkaaden hendrikvdkaaden Awaiting requested review from hendrikvdkaaden

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanmantel @dkaera @SEGVeenstra