Skip to content

Minor fix: blisp_device_flash_erase errors were ignored #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pavlos1 wants to merge 1 commit into from
Closed

Minor fix: blisp_device_flash_erase errors were ignored #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/blisp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,13 +360,13 @@ blisp_return_t blisp_device_flash_erase(struct blisp_device* device,
*(uint32_t*)(payload + 4) = end_address;

blisp_return_t ret = blisp_send_command(device, 0x30, payload, 8, true);
if (ret < 0)
if (ret != BLISP_OK)
return ret;
do {
ret = blisp_receive_response(device, false);
} while (ret == BLISP_ERR_PENDING);

return 0;
return ret;
}

blisp_return_t blisp_device_flash_write(struct blisp_device* device,
Expand Down Expand Up @@ -414,4 +414,4 @@ blisp_return_t blisp_device_reset(struct blisp_device* device) {
void blisp_device_close(struct blisp_device* device) {
struct sp_port* serial_port = device->serial_port;
sp_close(serial_port);
}
}