Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto infer device for SPLADE #49

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Auto infer device for SPLADE #49

merged 6 commits into from
Nov 15, 2023

Conversation

acatav
Copy link
Collaborator

@acatav acatav commented Sep 14, 2023 •
edited
Loading

Problem

Device currently not inferred automatically for SPLADE

Solution

Use torch to automatically infer device, and allow override

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Added unit tests

@acatav acatav requested a review from miararoy September 14, 2023 13:08
igiloh-pinecone
igiloh-pinecone suggested changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acatav I don't see why the user would need to manually pass in a device. This can simoly happen automatically

README.md Outdated Show resolved Hide resolved
@acatav acatav changed the title Update README.md Auto infer device for local models Nov 14, 2023
@acatav acatav changed the title Auto infer device for local models Auto infer device for SPLADE Nov 14, 2023
igiloh-pinecone
igiloh-pinecone approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatav acatav merged commit d580767 into main Nov 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

@miararoy miararoy Awaiting requested review from miararoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatav @igiloh-pinecone