allow mmh3 4.X #77
Closed
allow mmh3 4.X #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiloh-pinecone
approved these changes
Mar 22, 2024
pyproject.toml
Outdated
| @@ -12,7 +12,7 @@ torch = { version = ">=1.13.1", optional = true } | |||
| transformers = { version = ">=4.26.1", optional = true } | |||
| sentence-transformers = { version = ">=2.0.0", optional = true } | |||
| wget = "^3.2" | |||
| mmh3 = "^3.1.0" | |||
| mmh3 = "^3.1.0 || ^4.0.0" | |||
There was a problem hiding this comment.
You van simply do >3.1.0, and then it's anything bigger than 3.1, including 4.0
|
Duplicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users got into a dependency hell due to restriction of mmh3 to be 3.X and not allowing 4.X
Solution
Allow mmh3 4.X, according to the docs and some local tests there is no difference in encodings.
Type of Change
Test Plan
Tested locally comparison between versions to make sure the aligned, also CI have tests for BM25 and I run with both versions