Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variables: add @@global.tidb_accelerate_user_creation_update #19834

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

system-variables: add @@global.tidb_accelerate_user_creation_update #19834

wants to merge 8 commits into from

Conversation

tiancaiamao
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

pingcap/tidb#58512

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

pingcap/tidb#58512

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2025
@tiancaiamao tiancaiamao mentioned this pull request Feb 14, 2025
Open
16 tasks
lcwangchao
lcwangchao reviewed Feb 14, 2025
View reviewed changes
system-variables.md Outdated
- 是否受 Hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value) 控制：否
- 类型：布尔型
- 默认值：`OFF`
- 当系统中创建的 SQL 用户数量过多(比如10万以上)之后，创建用户/修改密码/设置权限等一些操作会受到比较严重的性能影响。原因是每次用户更新会涉及重新加载全部用户数据，这样的场景下建议将该变量设置为 `ON`。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

打开有什么副作用需要说明么？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

打开完全没有任何副作用...
感觉下个版本默认打开算了

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiancaiamao 打开应该是用户登录最长有 100ms 左右的延迟。这个等客户后续的测试反馈，如果比较好，我们在下一个 LTS 版本修改默认值吧。

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 14, 2025

@lcwangchao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. v9.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR’s assignee is translating this PR. labels Feb 20, 2025
@hfxsd hfxsd self-assigned this Feb 20, 2025
@hfxsd hfxsd requested a review from Frank945946 February 20, 2025 01:45
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Frank945946
Frank945946 approved these changes Feb 20, 2025
View reviewed changes
system-variables.md Outdated
- 是否受 Hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value) 控制：否
- 类型：布尔型
- 默认值：`OFF`
- 当系统中创建的 SQL 用户数量过多(比如10万以上)之后，创建用户/修改密码/设置权限等一些操作会受到比较严重的性能影响。原因是每次用户更新会涉及重新加载全部用户数据，这样的场景下建议将该变量设置为 `ON`。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiancaiamao 打开应该是用户登录最长有 100ms 左右的延迟。这个等客户后续的测试反馈，如果比较好，我们在下一个 LTS 版本修改默认值吧。

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao @Frank945946
Update system-variables.md
6e4ae4f 
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hfxsd
hfxsd reviewed Feb 20, 2025
View reviewed changes
Frank945946
Frank945946 reviewed Feb 20, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 20, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 20, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 21, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 21, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 21, 2025
View reviewed changes
@hfxsd hfxsd requested a review from lilin90 February 21, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd left review comments

@Frank945946 Frank945946 Frank945946 approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@hfxsd hfxsd

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @lcwangchao @hfxsd @Frank945946