Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix canal_json_storage test #1014

Merged
merged 2 commits into from
Feb 18, 2025
Merged

test: fix canal_json_storage test #1014

merged 2 commits into from
Feb 18, 2025

Conversation

wk989898
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #442

What is changed and how it works?

add columnSelector field to avoid panic

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 18, 2025
Copy link

ti-chi-bot bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-18 10:04:15.497430715 +0000 UTC m=+955697.893652761: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit e4f3520 into master Feb 18, 2025
11 of 12 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wk989898-patch-1 branch February 18, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants