Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix upstream database switch #10593

Merged
merged 3 commits into from
Feb 27, 2024
Merged

test: fix upstream database switch #10593

merged 3 commits into from
Feb 27, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Feb 7, 2024

What problem does this PR solve?

Issue Number: close #3353

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024
@okJiang
Copy link
Member Author

okJiang commented Feb 7, 2024

/check-issue-triage-complete

@okJiang
Copy link
Member Author

okJiang commented Feb 7, 2024

/cc @lance6716 @GMHDBJD

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 7, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-07 07:07:43.343833741 +0000 UTC m=+340588.910603631: ☑️ agreed by lance6716.
  • 2024-02-07 08:46:25.765281425 +0000 UTC m=+346511.332051299: ☑️ agreed by GMHDBJD.

@lance6716
Copy link
Contributor

/retest

11 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@okJiang
Copy link
Member Author

okJiang commented Feb 21, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Feb 27, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit d36cc29 into pingcap:master Feb 27, 2024
13 checks passed
@okJiang okJiang deleted the test-ci branch February 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test upstream-database-switch is not stable
4 participants