Fix changefeed stuck problem when overwrite resume with a forward checkpointTs #12056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note
ti-chi-bot
bot
added
cherry-pick-approved
asddongmen
reviewed
Feb 11, 2025
tests/integration_tests/run_group.sh
Outdated
| @@ -10,7 +10,7 @@ group=$2 | |||
| # Other tests that only support mysql: batch_update_to_no_batch ddl_reentrant | |||
| # changefeed_fast_fail changefeed_resume_with_checkpoint_ts sequence | |||
| # multi_cdc_cluster capture_suicide_while_balance_table | |||
| mysql_only="bdr_mode capture_suicide_while_balance_table syncpoint server_config_compatibility changefeed_dup_error_restart safe_mode" | |||
| mysql_only="bdr_mode capture_suicide_while_balance_table syncpoint server_config_compatibility changefeed_dup_error_restart overwrite_resume_with_syncpoint" | |||
There was a problem hiding this comment.
Please move this test to mysql_only_http group to make CI faster.
asddongmen
approved these changes
Feb 11, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
lidezhu
approved these changes
Feb 11, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #12055
What is changed and how it works?
resolvedTsto0when the changefeed is paused.resolvedTsfrom being smaller than thecheckpointTswhen the changefeed is initializing.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note