spec for joint consensus #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
reviewed
Nov 16, 2018
|
|
||
| \* The members of the server at that time. | ||
| VARIABLE voters | ||
| VARIABLE nextVoters |
There was a problem hiding this comment.
Do we need to consider learners? It's possible to promote a learner, remove them, or add them during Joint Consensus.
There was a problem hiding this comment.
Maybe later. It will increase the state space.
Hoverbear
reviewed
Nov 16, 2018
JointConsensus/JointConsensus.tla
Outdated
|
|
||
| \* Get the maximum config from log[1..l]. | ||
| GetMaxConfigIndex(i, l) == | ||
| LET chonfigIndexes == {index \in 1..l: log[i][index].type = ConfigEntry} |
There was a problem hiding this comment.
I think you mispelled configIndexes here.
|
don't leave description empty, I don't know what you want to do @nolouch |
siddontang
reviewed
Dec 11, 2018
| \* The candidate the server voted for in its current term, or | ||
| \* Nil if it hasn't voted for any. | ||
| VARIABLE votedFor | ||
| serverVars == <<currentTerm, state, votedFor,allServers, voters,nextVoters>> |
Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 6 in raft paper introduce the joint consensus, this is a TLA+ part for it. and it is modified from the origin raft.tla