agus #271
Open
agus #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ked out master branch on the project root instead of the modules root.
Added publishing file group tag for config file so we can use php artisan vendor:publish --tag=config
Added publishing group tag for config file
fixed missing stub replacements
When some extension already extended \Illuminate\View\FileViewFinder with additional view paths, we need to consider all of them. Example: https://github.com/igaster/laravel-theme Here paths will be like resources/<theme>/views, resources/views - we need to check modules template files in all of them (according to themes fallback). So, in our case it will become resources/<theme>/views/module/<module> and resources/views/module/<module> (last one is the same as `$viewPath` variable. Why not publishes themes templates? IMO, modules should not be supplied with strange themes, unless it is module bringing specific theme, but in this case this module provider could do publish by itself. Thanks
Set command module:migrate-rollback to run modules in reverse order
Ordering boot provider, now config module supports the languages module.
Order boot provider, supports the lang module
he create wrong path to controller namespace
Fix namespace path of Controller
…ommand. Otherwise module:update looks at module.json for its own dependencies.
Fix caching problem.
Updated stub to use all the paths of view finder
Installer process checkout on project root
Switched to singleton
Fixing deprecated method bindShared
This should call $name.'DatabaseSeeder' instead ob $name.'TableSeeder'
Fix for php artisan module:seed command
fix wrong paths in service provider
Update index.stub
Allow caching of the json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d