fix dict key failed in requests (#713)

> add testcase for **parameters
pinpoint-apm · Jan 2, 2025 · 0a33d1d · 0a33d1d
1 parent 0710996
commit 0a33d1d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/plugins/PY/pinpointPy/libs/_requests/NextSpanPlugin.py b/plugins/PY/pinpointPy/libs/_requests/NextSpanPlugin.py
@@ -46,7 +46,7 @@ def isSample(*args, **kwargs):
 
     def onBefore(self, parentId, *args, **kwargs):
         traceId, _args, _kwargs = super().onBefore(parentId, *args, **kwargs)
-        url = _args[1]
+        url = kwargs.get('url') or args[1]
         target = urlparse(url).netloc
         ###############################################################
         pinpoint.add_trace_header(

diff --git a/plugins/PY/pinpointPy/libs/_requests/test_case.py b/plugins/PY/pinpointPy/libs/_requests/test_case.py
@@ -65,6 +65,16 @@ def test_request(self):
         httpbin = create_http_bin_response(body.text)
         self.assertIn(Defines.PP_HEADER_PINPOINT_SPANID, httpbin.headers)
 
+    @PinTransaction("testcase", GenTestHeader())
+    def test_request_kwargs(self):
+        import requests
+        parameters = {
+            'method': "POST", "url": 'http://httpbin/anything', "data": 'abc'
+        }
+        body = requests.request(**parameters)
+        httpbin = create_http_bin_response(body.text)
+        self.assertIn(Defines.PP_HEADER_PINPOINT_SPANID, httpbin.headers)
+
     def test_request_no_transaction(self):
         import requests
         from threading import Thread