Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(py): py plugins #555

Merged
merged 1 commit into from
Nov 21, 2023
Merged

ci(py): py plugins #555

merged 1 commit into from
Nov 21, 2023

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Nov 21, 2023

  • add--exit-code-from python-plugins
  • bug from _urlib
  • fix get_logger

@eeliu
ci(py): py plugins
3cfd8ac 
-  add--exit-code-from python-plugins
- bug from _urlib
- fix get_logger
@eeliu eeliu mentioned this pull request Nov 21, 2023
Closed
5 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (9496d50) 76.64% compared to head (3cfd8ac) 79.05%.
Report is 20 commits behind head on dev.

Files Patch % Lines
common/src/common.cpp 63.80% 59 Missing ⚠️
common/src/ConnectionPool/TransLayer.h 66.34% 35 Missing ⚠️
common/src/Context/ContextType.h 58.33% 5 Missing ⚠️
common/src/ConnectionPool/TransLayer.cpp 85.18% 4 Missing ⚠️
common/src/Logging.cpp 85.71% 2 Missing ⚠️
common/src/NodePool/PoolManager.cpp 96.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #555      +/-   ##
==========================================
+ Coverage   76.64%   79.05%   +2.40%     
==========================================
  Files          18       18              
  Lines        1032     1074      +42     
==========================================
+ Hits          791      849      +58     
+ Misses        241      225      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu merged commit a4369f9 into pinpoint-apm:dev Nov 21, 2023
16 of 17 checks passed
@eeliu eeliu deleted the fix-ci-bug branch November 21, 2023 06:39
@eeliu eeliu self-assigned this Nov 24, 2023
@eeliu eeliu added this to the v0.4.12 milestone Dec 4, 2023
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
ci(py): py plugins (#555)
bf08141 
- add--exit-code-from python-plugins
- bug from _urlib
- fix get_logger
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
ci(py): py plugins (#555)
77f5c34 
- add--exit-code-from python-plugins
- bug from _urlib
- fix get_logger
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
ci(py): py plugins (#555)
eee8368 
- add--exit-code-from python-plugins
- bug from _urlib
- fix get_logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eeliu eeliu

Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
1 participant
@eeliu