Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove one more "/" #562

Merged
merged 1 commit into from
Nov 23, 2023

remove one more "/"

e64077a
Select commit
Loading
Failed to load commit list.
Merged

remove one more "/" #562

remove one more "/"
e64077a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 23, 2023 in 1s

78.95% (+2.30%) compared to 9496d50

View this Pull Request on Codecov

78.95% (+2.30%) compared to 9496d50

Details

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (9496d50) 76.64% compared to head (e64077a) 78.95%.
Report is 30 commits behind head on dev.

Files Patch % Lines
common/src/common.cpp 63.80% 59 Missing ⚠️
common/src/ConnectionPool/TransLayer.h 66.34% 35 Missing ⚠️
common/src/Context/ContextType.h 58.33% 5 Missing ⚠️
common/src/ConnectionPool/TransLayer.cpp 85.18% 4 Missing ⚠️
common/src/Logging.cpp 85.71% 2 Missing ⚠️
common/src/NodePool/PoolManager.cpp 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #562      +/-   ##
==========================================
+ Coverage   76.64%   78.95%   +2.30%     
==========================================
  Files          18       18              
  Lines        1032     1074      +42     
==========================================
+ Hits          791      848      +57     
+ Misses        241      226      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.