Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] support windows/macOS #657

Merged
merged 25 commits into from
Aug 1, 2024
Merged

[PHP] support windows/macOS #657

merged 25 commits into from
Aug 1, 2024

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Jul 31, 2024

Describe your changes

why we need this pr?

  • Support pinpoint_php on windows and macos
  • pecl install

Issue ticket number and link

#656

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (5187cc0) to head (5c903b7).
Report is 10 commits behind head on dev.

Files Patch % Lines
common/src/common.cpp 0.00% 3 Missing and 1 partial ⚠️
common/src/Cache/State.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #657      +/-   ##
==========================================
- Coverage   80.79%   80.63%   -0.16%     
==========================================
  Files          22       22              
  Lines        1536     1539       +3     
  Branches      165      168       +3     
==========================================
  Hits         1241     1241              
- Misses        162      164       +2     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu force-pushed the support-windows branch from 125483a to f5438d1 Compare July 31, 2024 07:35
@eeliu eeliu requested a review from Evelyn0927 August 1, 2024 02:07
@eeliu eeliu force-pushed the support-windows branch 3 times, most recently from 199d890 to c3f7427 Compare August 1, 2024 03:21
@eeliu eeliu changed the title Support windows [PHP] support windows/macOS Aug 1, 2024
@eeliu eeliu added this to the 0.6-windows-macOS milestone Aug 1, 2024
Copy link
Collaborator

@mayingping-Bella mayingping-Bella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeliu eeliu merged commit d0de218 into pinpoint-apm:dev Aug 1, 2024
65 of 73 checks passed
@eeliu eeliu deleted the support-windows branch August 1, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants