Fix build warnings

[remicollet]

To avoid missing real errors hidden by warning flood.

2 [-Wdeprecated-declarations] are not fixed, because in bundled library

libtool: compile:  g++ -I. -I/work/GIT/pecl-and-ext/pinpoint -I/work/GIT/pecl-and-ext/pinpoint/include -I/work/GIT/pecl-and-ext/pinpoint/main -I/work/GIT/pecl-and-ext/pinpoint -I/usr/include/php -I/usr/include/php/main -I/usr/include/php/TSRM -I/usr/include/php/Zend -I/usr/include/php/ext -I/usr/include/php/ext/date/lib -I/work/GIT/pecl-and-ext/pinpoint/common/include -I/work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/include -I/work/GIT/pecl-and-ext/pinpoint/common/src -DHAVE_CONFIG_H -O2 -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -DZEND_COMPILE_DL_EXT=1 -c /work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/lib_json/json_reader.cpp -MMD -MF common/jsoncpp/lib_json/json_reader.dep -MT common/jsoncpp/lib_json/json_reader.lo  -fPIC -DPIC -o common/jsoncpp/lib_json/.libs/json_reader.o
/work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/lib_json/json_reader.cpp:756:34: warning: 'Reader' is deprecated: Use CharReader and CharReaderBuilder instead. [-Wdeprecated-declarations]
  756 | Reader::Char Reader::getNextChar() {
      |                                  ^
In file included from /work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/lib_json/json_reader.cpp:10:
/work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/include/json/reader.h:37:63: note: declared here
   37 |     "Use CharReader and CharReaderBuilder instead.") JSON_API Reader {
      |                                                               ^~~~~~
/work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/lib_json/json_reader.cpp:810:21: warning: 'Reader' is deprecated: Use CharReader and CharReaderBuilder instead. [-Wdeprecated-declarations]
  810 | std::vector<Reader::StructuredError> Reader::getStructuredErrors() const {
      |                     ^~~~~~~~~~~~~~~
/work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/include/json/reader.h:37:63: note: declared here
   37 |     "Use CharReader and CharReaderBuilder instead.") JSON_API Reader {
      |                                                               ^~~~~~

[eeliu]

/work/GIT/pecl-and-ext/pinpoint/common/jsoncpp/lib_json/json_reader.cpp:756:34: warning: 'Reader' is deprecated: Use CharReader and CharReaderBuilder instead. [-Wdeprecated-declarations]

yes, those warring comes from jsoncpp( a older version)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (5187cc0) to head (47c602c).
Report is 28 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #667      +/-   ##
==========================================
- Coverage   80.79%   80.63%   -0.16%     
==========================================
  Files          22       22              
  Lines        1536     1539       +3     
  Branches      165      166       +1     
==========================================
  Hits         1241     1241              
- Misses        162      164       +2     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eeliu]

LGTM

[eeliu]

it's ok to disable this function.