Add Parsing functionality for service headers #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garionpin
reviewed
Jan 8, 2025
webapp/src/main/java/com/box/l10n/mojito/security/ServiceIdentifierParserConfig.java
Outdated
Show resolved
Hide resolved
garionpin
approved these changes
Jan 8, 2025
byronantak
force-pushed
the
feat/service-header-parsing
branch
from
0a29eae to
e0d0b8d
Compare
byronantak
force-pushed
the
feat/service-header-parsing
branch
from
e0d0b8d to
4737c92
Compare
byronantak
force-pushed
the
feat/service-header-parsing
branch
from
4737c92 to
68a23fc
Compare
garionpin
reviewed
Jan 13, 2025
webapp/src/main/java/com/box/l10n/mojito/security/ServiceKeyValueParser.java
Outdated
Show resolved
Hide resolved
garionpin
approved these changes
Jan 13, 2025
byronantak
force-pushed
the
feat/service-header-parsing
branch
from
68a23fc to
f92bd2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our service headers are a more complex string type and not solely the identifier of the service.
As such, It is necessary to parse the string to extract just the service identifier.
An example such a header:
By=example.com/mojito/dev;Hash=hash;URI=serviceExample