Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiNest #1319
base: main
Are you sure you want to change the base?
MultiNest #1319
Changes from all commits
82348f1
4a52bda
7365948
dc5a450
b3214d8
6d2f03c
f67bf4b
1293a5d
70c45bf
b88bc72
1f07e16
c3fad40
3d5815a
9ab1259
3a6cc29
e2f0cc5
fc8564e
2437908
80052b1
2afc8f6
b803fd7
1ca047b
13460da
40df3e7
394cc72
c2b8149
c90c2a1
cb0b1b1
734f37b
8e684f1
7c55a8d
61dfce4
e4100e7
7bf0ef2
a602418
64136f7
8baa289
c2b445a
e0b71e9
1af9adc
eefd07e
aaf3657
2a9e5a7
e7cb8cd
2b45b98
316c275
c084e01
6110010
1996e4b
a9eed9f
4f3c3a7
bb29984
532cd67
93d9330
cdfba3f
09f0975
ae3dce7
a01a9d1
bb24a1f
2c88bae
9d949dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No you're scipy special 🥰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing there's a technical difference between multiple ellipsoids and ellipsoid count being above one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do all nested samplers use ellipsoids?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the other controllers we handle this in a more general way, by letting each sampler/optimiser define a method _log_init (that does nothing by default) which can update the logging
https://github.com/pints-team/pints/blob/master/pints/_mcmc/__init__.py#L623-L624
and
_log_write
:https://github.com/pints-team/pints/blob/master/pints/_mcmc/__init__.py#L820-L821
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links to the classes with :class:
pints.X
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should it be a maths N, and maths again below?