LogPDF storage issue with multi-chain methods #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd make sure all mention single/multi chain
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1700 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 9695 9699 +4
=========================================
+ Hits 9695 9699 +4 ☔ View full report in Codecov by Sentry. |
|
Very easy fix @martinjrobins ! |
MichaelClerx
commented
Dec 19, 2024
| @@ -706,7 +726,9 @@ def test_log_pdf_storage_in_memory_multi(self): | |||
| x0 = np.array(self.real_parameters) * 1.05 | |||
| x1 = np.array(self.real_parameters) * 1.15 | |||
| x2 = np.array(self.real_parameters) * 0.95 | |||
| xs = [x0, x1, x2] | |||
| x3 = np.array(self.real_parameters) * 0.95 | |||
There was a problem hiding this comment.
This bit just removes a warning because diff ev wants you to use many chains
martinjrobins
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and fix for #1691
Touched a few more files than necessary, because I updated some docstrings while looking for a multi-chain method using sensitivities. There wasn't one, so I added a "fake" one for testing.