Skip to content

Update lint rules, force testify/assert #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

RyanPotat
Copy link
Member

@RyanPotat RyanPotat commented Mar 29, 2025

Description

Update lint rules to forbid the use of direct testing.T helpers. Removed multiple //nolint:cyclop by consequence of reduced if blocks.

Reference issue

pion/.goassets#222

@RyanPotat RyanPotat marked this pull request as draft March 29, 2025 07:40
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (e57dc04) to head (c9e37f9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         101      101           
  Lines        6831     6831           
=======================================
  Hits         5367     5367           
  Misses       1089     1089           
  Partials      375      375           
Flag Coverage Δ
go 78.59% <100.00%> (ø)
wasm 63.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeTurki JoeTurki self-assigned this Mar 29, 2025
@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch 4 times, most recently from 5fe6b5b to bc9ee54 Compare March 31, 2025 08:01
@JoeTurki JoeTurki force-pushed the RyanPotat/lint/test-helpers branch 2 times, most recently from ce9a8d5 to 7775f48 Compare March 31, 2025 08:14
@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch 3 times, most recently from 1abb8d3 to 0a07999 Compare April 8, 2025 08:52
@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch from 0a07999 to c9e37f9 Compare April 8, 2025 08:55
@RyanPotat RyanPotat marked this pull request as ready for review April 8, 2025 08:59
@Sean-Der Sean-Der merged commit 58d3b7e into master Apr 9, 2025
16 checks passed
@Sean-Der Sean-Der deleted the RyanPotat/lint/test-helpers branch April 9, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants