Skip to content

UDPMuxSink for UDPMux allows to inspect packets before being dropped#746

Open
astroza wants to merge 1 commit intopion:masterfrom
astroza:udpmux_sink
Open

UDPMuxSink for UDPMux allows to inspect packets before being dropped#746
astroza wants to merge 1 commit intopion:masterfrom
astroza:udpmux_sink

Conversation

@astroza
Copy link
Copy Markdown

@astroza astroza commented Nov 26, 2024

Description

This is one of the features that helped us to build a distributed version of Pion.

Inspecting UDPMux discarded packets makes it possible to evaluate and restore a PeerConnection if needed

Copy link
Copy Markdown
Contributor

@nils-ohlmeier nils-ohlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But someone else should probably review this as well.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2024

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.50%. Comparing base (35bb3fb) to head (589aef2).
⚠️ Report is 123 commits behind head on master.

Files with missing lines Patch % Lines
udp_mux.go 25.00% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   78.69%   78.50%   -0.20%     
==========================================
  Files          41       41              
  Lines        4769     4773       +4     
==========================================
- Hits         3753     3747       -6     
- Misses        783      790       +7     
- Partials      233      236       +3     
Flag Coverage Δ
go 78.50% <25.00%> (-0.20%) ⬇️
wasm 22.45% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sean-Der
Copy link
Copy Markdown
Member

@nils-ohlmeier You can merge anything without me! As long as it passes the tests I don't care. Nothing worse then waiting on a slow maintainer :)

@astorza that's really cool you were able to build a distributed version! Would you mind writing a test for this? Just assert that if set it really does get fired.

thank you so much for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants