-
-
Notifications
You must be signed in to change notification settings - Fork 33
Add tag option #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaorukobo
wants to merge
5
commits into
piotrmurach:master
Choose a base branch
from
kaorukobo:tag-option
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add tag option #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 13, 2025
houndci-bot
reviewed
Sep 13, 2025
e75f145 to
737b755
Compare
737b755 to
4ce2b8c
Compare
|
Ooh, I like this! Yes please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This adds a
tagoption toTTY::Command.newand therunmethod. This allows you to prepend any arbitrary string to the beginning of log output.To clearly show the differences from the existing codebase, the commits are split as follows:
Why are we doing this?
Currently, tty-command's log output only allows you to control whether UUIDs are on or off. Meaningless UUID strings make it very difficult to identify the output of multiple interleaved command executions.
Benefits
By allowing arbitrary strings to be displayed at the beginning of logs, you can easily identify the output of multiple interleaved command executions.
Drawbacks
None. All existing code will continue to work as before without any modifications.
Requirements
masterbranch?