Skip to content

Conversation

kadai0308
Copy link
Contributor

What this PR does

  1. Use toolregistry to download the sqldef binary.
  2. Implemented execution stage for applying schema to target DB.

Signed-off-by: kadai0308 <kadai0308@gmail.com>
@kadai0308 kadai0308 force-pushed the implement_execute_stage_for_sqldef_plugin branch from f72e978 to 8b5e9e7 Compare July 10, 2025 01:28
@t-kikuc
Copy link
Member

t-kikuc commented Jul 10, 2025

@kadai0308 Thank you.
Would you please split into smaller PRs? It's too tough to review.

# other
.DS_Store
.DS_Store
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Comment on lines 9 to 11

build:
go build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use make build/go to keep the consistency unless special reasons.

.PHONY: build/go

Signed-off-by: kadai0308 <kadai0308@gmail.com>
@kadai0308 kadai0308 closed this Jul 12, 2025
@kadai0308 kadai0308 reopened this Jul 12, 2025
@kadai0308 kadai0308 marked this pull request as draft July 12, 2025 03:37
Signed-off-by: kadai0308 <kadai0308@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants