-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for quickstart with raw manifests on README #5152
Conversation
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5152 +/- ##
==========================================
- Coverage 22.80% 22.79% -0.02%
==========================================
Files 412 412
Lines 43827 43827
==========================================
- Hits 9996 9990 -6
- Misses 33044 33050 +6
Partials 787 787 ☔ View full report in Codecov by Sentry. |
kubectl apply -n pipecd -f ./manifests/control-plane.yaml | ||
``` | ||
|
||
3. create piped on the Web UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's nice for users to show kubectl port-forward command and URL of the Web UI.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Warashi
It's a nice idea. But I wonder if I should do so 🤔
For me, this doc is like a memo to describe whats the manifest is.
Also there is the actual process of the quickstart on the docs. https://pipecd.dev/docs-v0.48.x/quickstart/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I got it. I agree that we have other documents about these manifests and don't have to show detailed commands here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
What this PR does / why we need it:
as title
Which issue(s) this PR fixes:
Part of #5148
Does this PR introduce a user-facing change?: