Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nits] fix docs to lowerCamelCase and add t.Parallel() #5173

Merged
merged 2 commits into from
Sep 2, 2024
Merged

[nits] fix docs to lowerCamelCase and add t.Parallel() #5173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a7dd9
fix SSOConfigOIDC: UpperCamel -> LowerCamel
t-kikuc Sep 2, 2024
f6c8a63
nits: add t.Parallel()
t-kikuc Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ...content/en/docs-dev/user-guide/managing-controlplane/configuration-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,12 @@ Must be one of the following objects:

| Field | Type | Description | Required |
|-|-|-|-|
| ClientId | string | The client id string of OpenID Connect oauth app. | Yes |
| ClientSecret | string | The client secret string of OpenID Connect oauth app. | Yes |
| Issuer | string | The address of OpenID Connect service. | Yes |
| RedirectUri | string | The address of the redirect URI. | Yes |
| AuthorizationEndpoint | string | The address of the authorization endpoint. | No |
| TokenEndpoint | string | The address of the token endpoint. | No |
| UserInfoEndpoint | string | The address of the user info endpoint. | No |
| ProxyUrl | string | The address of the proxy used while communicating with the OpenID Connect service. | No |
| Scopes | []string | Scopes to request from the OpenID Connect service. Default is `openid`. Some providers may require other scopes. | No |
| clientId | string | The client id string of OpenID Connect oauth app. | Yes |
| clientSecret | string | The client secret string of OpenID Connect oauth app. | Yes |
| issuer | string | The address of OpenID Connect service. | Yes |
| redirectUri | string | The address of the redirect URI. | Yes |
| authorizationEndpoint | string | The address of the authorization endpoint. | No |
| tokenEndpoint | string | The address of the token endpoint. | No |
| userInfoEndpoint | string | The address of the user info endpoint. | No |
| proxyUrl | string | The address of the proxy used while communicating with the OpenID Connect service. | No |
| scopes | []string | Scopes to request from the OpenID Connect service. Default is `openid`. Some providers may require other scopes. | No |
2 changes: 2 additions & 0 deletions pkg/app/server/httpapi/callback_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
)

func TestParseProjectAndState(t *testing.T) {
t.Parallel()
tests := []struct {
name string
formValues url.Values
Expand Down Expand Up @@ -79,6 +80,7 @@ func TestParseProjectAndState(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
req := httptest.NewRequest(http.MethodGet, "/", nil)
req.Form = tt.formValues

Expand Down
Loading