Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify spec for multi cluster deployment #5219

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Sep 20, 2024

What this PR does / why we need it:

I changed the location of the configuration for the multi-cluster deployment.
Before that, I considered setting the configs on each stage. But it would be better to unify the config for the target setting to reduce duplication.

apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
  name: microservice-a
  labels:
    env: prd
    team: product
  quickSync:
    prune: true
  input:
    multiTarget:
      - targetID: hoge
        provider:
          name: cluster-hoge # platform provider name
        manifests: ./cluster-hoge # the resource dir
        kubectlVersion: 1.30
        kustomizeDir: ./cluster-hoge
        kustomizeVersion: v5.4.3
        kustomizeOptions:
          enable-helm: ""
          load-restrictor: "LoadRestrictionsNone"
      - targetID: fuga
        provider:
          name: cluster-fuga # platform provider name
        kubectlVersion: 1.30
        kustomizeDir: ./cluster-fuga
        kustomizeVersion: v5.4.3
        kustomizeOptions:
          enable-helm: ""
          load-restrictor: "LoadRestrictionsNone"

Which issue(s) this PR fixes:

Part Of #5006

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.82%. Comparing base (5d3e17d) to head (35ff8ed).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5219   +/-   ##
=======================================
  Coverage   22.82%   22.82%           
=======================================
  Files         420      419    -1     
  Lines       45302    45297    -5     
=======================================
+ Hits        10340    10341    +1     
+ Misses      34166    34161    -5     
+ Partials      796      795    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo ffjlabo marked this pull request as ready for review September 20, 2024 07:43
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point specified 👍

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@khanhtc1202 khanhtc1202 merged commit 90f6a1f into master Sep 25, 2024
17 checks passed
@khanhtc1202 khanhtc1202 deleted the add-spec-of-kustomize-and-helm-options-for-multi-cluster-deployment branch September 25, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants