update file_size after write #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/resty/mongol/colmt.lua
- fixed cannot load by init_by_lua, because used ngx.var.pid in module file scope, so moved to function run time scope
revert back start from 0 for advance queries
we start the array count from 0 but need to add 1 to mongo array start from 0 lua from 1 start the array building loop from 0 and compensate it by adding 1 to seen_n and removing 1 from high_n seems to work??
- fixed to_bson incorrectly handle array index
…N. So, now will convert numerical key to string before store to mongodb. And for the best practice, should avoid to use numerical key. Because there may have conflit, for example: { 'aaa', ["1"] = 'bbb } is unknown behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small fix for gridfs_file write, to update file_size after successful write.
Without this, it is not possible to call write more than once, because this.file_size is always 0.