refactor: extract duplicated velocity calculation logic in Contact class #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
To eliminate the code duplication identified in the
Contact
class during the calculation of the relative velocity between two contact points (bodies A and B), the repeated instructions were extracted and centralized into a method namedcomputeRelativeVelocity
within theContact
class:This function takes the required parameters and performs the necessary calculations in-place by reference.
With this solution, the duplication has been effectively addressed, improving both the readability and understanding of the code through modularization and reuse of instructions. Additionally, any future changes to the calculation logic can now be made in a single function, avoiding the need to update all three occurrences of the routine.
Resolves #305