really disable fallback mounting to RO #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
disable-ro-fallback
branch
2 times, most recently
from
b48401c to
ac32d87
Compare
Passing the "rw" option is not enough. Careful reading of the manpage, verified by tests and reading of the source code of util-linux reveals that disabling the RO fallback only happens when you pass the "-w" flag. Then, also fix "ro" mounts in case of XFS, as XFS attempts to write even if passed the "ro" flag without the "norecovery" option. Fixes: 6deb565 ("disable fallback to RO mounts for RW volumes") Signed-off-by: Moritz Wanzenböck <moritz.wanzenboeck@linbit.com>
WanzenBug
force-pushed
the
disable-ro-fallback
branch
from
ac32d87 to
2b86f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the "rw" option is not enough. Careful reading of the manpage, verified by tests and reading of the source code of util-linux reveals that disabling the RO fallback only happens when you pass the "-w" flag.
Then, also fix "ro" mounts in case of XFS, as XFS attempts to write even if passed the "ro" flag without the "norecovery" option.
Fixes: 6deb565 ("disable fallback to RO mounts for RW volumes")