Move configuration changes to development.rb#6
Open
kmayer wants to merge 1 commit intopivotalexperimental:masterfrom
Open
Move configuration changes to development.rb#6kmayer wants to merge 1 commit intopivotalexperimental:masterfrom
kmayer wants to merge 1 commit intopivotalexperimental:masterfrom
Conversation
Since the gem is only included in the :development group, the engine is not available in "non-development" (e.g. production) environments Closes pivotalexperimental#5
Collaborator
|
Hi @kmayer! Originally i had the idea that this would be a non-production, but still staging and development, gem. I agree that, if style-guide were a local-only development tool, application.rb would be the wrong place. However, I'm more likely to deploy default production stuff to my staging environment, and then later on make conscientious decisions about what goes into production. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the gem is only included in the :development group, the engine is not available in "non-development" (e.g. production) environments
Closes #5