Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dedicated GroupingByGatherer #73

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Introduce dedicated GroupingByGatherer #73

merged 1 commit into from
Jan 20, 2025

Conversation

pivovarit
Copy link
Owner

No description provided.

@pivovarit pivovarit marked this pull request as ready for review December 17, 2024 14:02
@pivovarit pivovarit enabled auto-merge (squash) December 17, 2024 14:02
@pivovarit pivovarit requested a review from Copilot December 17, 2024 14:03
@pivovarit pivovarit disabled auto-merge December 17, 2024 14:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/main/java/com/pivovarit/gatherers/GroupingByGatherer.java:23

  • [nitpick] The method name 'initializer' is unconventional. Consider renaming it to 'supplier' for consistency with Java's Collector interface.
public Supplier<HashMap<K, Stream.Builder<T>>> initializer() {

src/main/java/com/pivovarit/gatherers/GroupingByGatherer.java:18

  • The error message 'classifier can't be null' could be more descriptive. Consider specifying the method or class it is related to.
Objects.requireNonNull(classifier, "classifier can't be null");

src/main/java/com/pivovarit/gatherers/GroupingByGatherer.java:19

  • The error message 'collector can't be null' could be more descriptive. Consider specifying the method or class it is related to.
Objects.requireNonNull(collector, "collector can't be null");
@pivovarit pivovarit enabled auto-merge (squash) January 20, 2025 06:38
@pivovarit pivovarit merged commit dafd30e into main Jan 20, 2025
2 checks passed
@pivovarit pivovarit deleted the grouping-by branch January 20, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant