[TASK] PM features and changes #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to include an image for attibutes
mabolek
reviewed
Dec 15, 2020
| public function getListingAttributes(): array | ||
| { | ||
| return $this->collection($this->getAttributes()) | ||
| ->filter(fn (Attribute $attribute) => $attribute->isShowInAttributeListing()) |
There was a problem hiding this comment.
Wouldn't it be better to just have showInAttributeListing()?
Suggested change
| ->filter(fn (Attribute $attribute) => $attribute->isShowInAttributeListing()) | |
| ->filter(fn (Attribute $attribute) => $attribute->showInAttributeListing()) |
mabolek
reviewed
Dec 15, 2020
Classes/Domain/Model/Product.php
Outdated
| * Returns Usp as array split by lines. | ||
| * @return array | ||
| */ | ||
| public function getUspList(): array |
There was a problem hiding this comment.
Suggested change
| public function getUspList(): array | |
| public function getUspArray(): array |
mabolek
requested changes
Dec 15, 2020
…ter out option attributes with empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #240, #239, #238