fix and improve timezone related functions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get the default timezone via CalendarApp to fix the issue change the 1st param of formatDate() from 'message' to 'date' unlock the limitation
automationai
commented
Jul 31, 2020
| * @param {string} format | ||
| * @param {string} timezone | ||
| * @return {string} Formatted date | ||
| */ | ||
| function formatDate(message, format, timezone) { | ||
| function formatDate(date, format, timezone) { |
There was a problem hiding this comment.
Change from 'message' to 'date' to unlock the limitation
automationai
commented
Jul 31, 2020
| @@ -500,8 +500,8 @@ function defaults_(options, defaults) { | |||
| * @return {string} | |||
| */ | |||
| function localTimezone_() { | |||
| var timezone = new Date().toTimeString().match(/\(([a-z0-9]+)\)/i); | |||
| return timezone.length ? timezone[1] : 'GMT'; | |||
| var timezone = CalendarApp.getDefaultCalendar().getTimeZone(); | |||
There was a problem hiding this comment.
Use CalendarApp to get default timezone to fix the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get the default timezone via CalendarApp to fix the issue
change the 1st param of formatDate() from 'message' to 'date' unlock the limitation