update for v8 manifest compatibility (#49)

pixijs · Nov 17, 2023 · c61d4d4 · c61d4d4
1 parent 1329c52
commit c61d4d4
Show file tree

Hide file tree

Showing 5 changed files with 91 additions and 95 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -9,10 +9,6 @@ jobs:
     steps:
       - name: Check out repository code
         uses: actions/checkout@v3
-      - name: Install GitHub CLI
-        run: |
-          brew update
-          brew install gh
       - name: Generate Release
         run: gh release create ${{github.ref_name}} --generate-notes
         env:

diff --git a/packages/manifest/README.md b/packages/manifest/README.md
@@ -45,15 +45,15 @@ This will generate two bundles called `preload` and `game` in the manifest file.
 - `createShortcuts` - Whether to create shortcuts for each bundle. Defaults to `false`. If enabled the manifest will try to create the shortest path for an asset. e.g.
 ```json
 {
-    "name": ["game/char.png", "game.png"],
-    "srcs": ["game/char.png"]
+    "alias": ["game/char.png", "game.png"],
+    "src": ["game/char.png"]
 }
 ```
 - `trimExtensions` - Whether to trim the extensions from the asset names. Defaults to `false`. If enabled the manifest will try to create the shortest path for an asset. e.g.
 ```json
 {
-    "name": ["game/char.png", "game/char"],
-    "srcs": ["game/char.png"]
+    "alias": ["game/char.png", "game/char"],
+    "src": ["game/char.png"]
 }
 ```
 - `defaultParser` - The default parser to use on a transformed asset

diff --git a/packages/manifest/src/pixi.ts b/packages/manifest/src/pixi.ts
@@ -12,8 +12,8 @@ export interface PixiManifest
 
 export interface PixiManifestEntry
 {
-    name: string | string[];
-    srcs: string | string[];
+    alias: string | string[];
+    src: string | string[];
     data?: {
         tags: Tags;
         [x: string]: any;
@@ -63,7 +63,7 @@ function finish(
     {
         const nameMap = new Map<PixiManifestEntry, string[]>();
 
-        bundles.forEach((bundle) => bundle.assets.forEach((asset) => nameMap.set(asset, asset.name as string[])));
+        bundles.forEach((bundle) => bundle.assets.forEach((asset) => nameMap.set(asset, asset.alias as string[])));
 
         const arrays = Array.from(nameMap.values());
         const sets = arrays.map((arr) => new Set(arr));
@@ -75,7 +75,7 @@ function finish(
             {
                 const names = nameMap.get(asset) as string[];
 
-                asset.name = uniqueArrays.find((arr) => arr.every((x) => names.includes(x))) as string[];
+                asset.alias = uniqueArrays.find((arr) => arr.every((x) => names.includes(x))) as string[];
             });
         });
     }
@@ -141,7 +141,7 @@ function collect(
                 };
             }
 
-            entry.name = getShortNames(entry.name, options);
+            entry.alias = getShortNames(entry.alias, options);
         });
         bundle.assets.push(...result);
     }
@@ -164,8 +164,8 @@ export function defaultPixiParser(tree: ChildTree, processor: Processor, _option
         const name = processor.trimOutputPath(file.name ?? file.paths[0]);
 
         const res: PixiManifestEntry =  {
-            name,
-            srcs: file.paths.map((path) => processor.trimOutputPath(path)),
+            alias: name,
+            src: file.paths.map((path) => processor.trimOutputPath(path)),
         };
 
         // eslint-disable-next-line @typescript-eslint/no-unused-expressions