fix: Fix combineSkeletons #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the same skinIndex might be shared between different skeleton groups the condition to use the same skin index attribute: - the same skin index attribute - and the skeleton is same - and the bone set is same In order to create a map from those three conditions to new skin index attributes, I implemented `ObjectIndexDispatcher` (low confidence implementation. would you come up with a better implementation/name?) I hope this improved the readability
ke456-png
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
VRMUtils.combineSkeletons.The same skinIndex might be shared between different skeleton groups.
The condition to use the same skin index attribute:
In order to create a map from those three conditions to new skin index attributes, I implemented
ObjectIndexDispatcher.(low confidence implementation. would you come up with a better implementation/name?)
I hope this improved the readability.
TODOs
Points need review