speed up tests by by removing redundant logins

[piyush-jaiswal]

Summary by CodeRabbit

• Tests

  • Streamlined authentication setup in tests to reduce duplication and improve performance.
  • Consolidated imports and minor formatting cleanups for consistency.
  • Added stronger post-condition assertions to validate data integrity.
  • Simplified test signatures and flows for clearer token-error scenarios.
  • Decoupled entity creation from authentication to improve test independence and readability.

• Chores/Refactor

  • Optimized test utilities with caching to reduce redundant setup work, improving test speed and stability.

[coderabbitai]

Walkthrough

Introduces lazy caching for the create_authenticated_headers fixture in tests, consolidates a duplicate import in auth tests, and updates multiple test files to decouple entity creation from authentication by removing direct header usage. Adds post-condition assertions in a category duplicate-name test and adjusts token-error tests to rely on get_headers.

Changes

Cohort / File(s)	Summary
Fixture: cached auth header tests/conftest.py	Adds nonlocal cache to create_authenticated_headers; performs register/login once and reuses stored headers on subsequent calls.
Auth test import cleanup tests/test_auth.py	Consolidates decode_token import to top; removes duplicate import; minor formatting (blank line).
Category tests: auth decoupling + assertions tests/test_category.py	Removes create_authenticated_headers usage in duplicate-name test; updates signature; adds assertions ensuring only one category exists and the named category is present post-IntegrityError.
Product token-error tests: header removal tests/test_product.py	Drops create_authenticated_headers from two tests’ signatures and calls; relies on get_headers for token checks; creation helpers called without headers.
Subcategory tests: header removal and signature updates tests/test_subcategory.py	Removes create_authenticated_headers usage across several tests; updates signatures accordingly; entity creation occurs without headers; token checks use get_headers.
Relationships tests: separate setup from auth tests/test_relationships.py	Removes headers from entity creation helpers; applies headers only to update/pagination requests; maintains existing assertions.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Test
  participant Fixture as create_authenticated_headers (fixture)
  participant Auth as Auth API

  rect rgba(200,230,255,0.3)
  note over Fixture: First call
  Test->>Fixture: request headers
  alt cache empty
    Fixture->>Auth: register + login
    Auth-->>Fixture: access token
    Fixture->>Fixture: store headers in cache
  end
  Fixture-->>Test: cached headers
  end

  rect rgba(220,255,220,0.3)
  note over Fixture: Subsequent calls
  Test->>Fixture: request headers
  Fixture-->>Test: return cached headers (no API calls)
  end

Loading

sequenceDiagram
  autonumber
  actor Test
  participant Helpers as create_* helpers
  participant API as REST API
  participant Headers as get_headers

  rect rgba(245,245,245,1)
  note over Test,Helpers: Entity setup without auth
  Test->>Helpers: create_category / create_subcategory / create_product
  Helpers->>API: POST (no headers)
  API-->>Helpers: created entity
  end

  rect rgba(255,240,200,0.5)
  note over Test,API: Token check phase
  Test->>Headers: get_headers(expected_token_state)
  Headers-->>Test: headers (valid/invalid/missing)
  Test->>API: PATCH/DELETE/GET with headers
  API-->>Test: response (success or token error)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Add subcategory tests #10 — Introduces the create_authenticated_headers fixture; current PR modifies its behavior to cache headers.
• Add relationship tests #13 — Adjusts fixtures depending on create_authenticated_headers; current caching change affects those call sites.
• add product tests #11 — Updates product tests around token/header handling; current PR further refines header usage in product token-error tests.

Poem

I hopped through tests with nimble cheer,
Cached my token, kept it near.
No more headers everywhere—
Create, then check with careful flair.
One bunny, one cache, much less stress,
Thump-thump: green lights, fewer mess. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly describes the main change of eliminating redundant authentication calls to speed up the test suite, which aligns with the pull request’s core objective.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/tests/remove-re-logins

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3be44fe and 08bdd37.

📒 Files selected for processing (6)

• tests/conftest.py (1 hunks)
• tests/test_auth.py (2 hunks)
• tests/test_category.py (1 hunks)
• tests/test_product.py (2 hunks)
• tests/test_relationships.py (5 hunks)
• tests/test_subcategory.py (4 hunks)

🧰 Additional context used

🧬 Code graph analysis (5)

tests/conftest.py (1)

tests/utils.py (1)

• get_auth_header (13-14)

tests/test_product.py (2)

tests/conftest.py (1)

• create_product (87-98)

app/routes.py (1)

• create_product (140-191)

tests/test_relationships.py (1)

tests/conftest.py (4)

• create_subcategory (72-83)
• create_category (59-68)
• create_authenticated_headers (43-55)
• create_product (87-98)

tests/test_subcategory.py (1)

tests/conftest.py (1)

• create_subcategory (72-83)

tests/test_category.py (1)

tests/conftest.py (1)

• create_category (59-68)

🔇 Additional comments (14)

tests/test_auth.py (1)

4-4: LGTM! Import consolidation improves code organization.

Moving the decode_token import to the top-level consolidates imports and eliminates duplication.

tests/conftest.py (1)

43-55: LGTM! Effective caching reduces redundant authentication.

The lazy initialization pattern correctly caches authentication headers within a single test execution, eliminating redundant login calls. The nonlocal declaration properly captures the outer scope variable.

Fixture scope note: This fixture uses the default function scope, meaning each test gets its own cached headers instance. This provides proper test isolation while achieving the PR's performance goal.

tests/test_relationships.py (5)

103-112: LGTM! Efficient header reuse via cached fixture.

Entity creation now relies on the default headers=None parameter in the create_* fixtures, which internally calls the cached create_authenticated_headers(). The update operation explicitly retrieves the cached headers. This eliminates redundant logins while maintaining proper authentication.

---

115-130: LGTM! Consistent caching pattern applied.

Multiple entity creations now use cached headers via fixture defaults, with explicit header retrieval only for the update operation.

---

133-165: LGTM! Proper authentication maintained in error paths.

Entity creation and multiple update attempts with IntegrityError handling all correctly use cached authentication headers.

---

218-224: LGTM! Read operations benefit from cached headers.

Entity creation uses cached headers via fixture defaults, while the GET operation doesn't require authentication.

---

231-245: LGTM! Pagination tests optimized with header caching.

Multiple product creations in the loop all reuse the same cached authentication headers, significantly reducing test execution time.

tests/test_category.py (1)

42-51: LGTM! Header caching plus stronger assertions.

The test now uses cached authentication headers (eliminating redundant login), and the added post-condition assertions verify that the duplicate insertion was properly rejected and the database state remains consistent.

tests/test_product.py (2)

155-169: LGTM! Cached headers for setup, token errors still tested.

Product creation now uses cached authentication headers via the fixture default. The token error scenarios (expired, invalid, missing) are still properly tested on the update operation.

---

179-188: LGTM! Consistent pattern applied to delete tests.

Similar to the update test, product creation uses cached headers while delete operation tests properly verify token error handling.

tests/test_subcategory.py (4)

42-51: LGTM! Duplicate name test now uses cached headers.

The test signature is simplified by removing create_authenticated_headers, with both subcategory creation calls now using cached headers via the fixture default. Post-condition assertions correctly verify database state after the duplicate rejection.

---

64-75: LGTM! Efficient header reuse in read operations.

Multiple subcategory creations now share cached authentication headers, reducing test execution time.

---

129-143: LGTM! Token error testing pattern consistently applied.

Subcategory creation uses cached valid headers, while the update operation correctly tests authentication failures with invalid tokens.

---

153-162: LGTM! Delete operation follows the same efficient pattern.

Consistent with other token error tests, creation uses cached headers while deletion tests authentication failures.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Preview: https://ecommerce-rest-7xj2com3m-piyush-jaiswals-projects.vercel.app