Merged
Conversation
ctcpip
force-pushed
the
forkadu
branch
8 times, most recently
from
a29282d to
e8890ac
Compare
fork PRs targeting main will never be able to pass integration tests or action-in-action due to the lack of permissions that fork action/workflow get: - it will not have write permission on the main repo - it will not have write permission on the wesleytodd/meeting-maker repo - it will not have write permission on its own repo because it's running in the main repo context therefore, if you want to see the integration tests and action-in-action test passing, then a PR needs to be created in the fork repo
bjohansebas
approved these changes
Aug 8, 2025
wesleytodd
approved these changes
Aug 8, 2025
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
Pending the one question, this looks good.
| const mainRepo = 'pkgjs/meet' | ||
|
|
||
| function getTestRepo () { | ||
| let testRepo = { owner: 'wesleytodd', repo: 'meeting-maker' } // ✨ Wes, the meeting maker ✨ |
|
|
||
| testint: | ||
| runs-on: ubuntu-latest | ||
| # only run if not a fork PR targeting main repo due to permissions |
Member
There was a problem hiding this comment.
Fwiw I am not sure this comment is any more clear than the code lol. Just to make sure I understand what you are saying here:
This checks to see if you are making a fork targeting your fork, not this repo?
If so, that seems like a reasonable middle ground to allow testing without leaking secrets.
Contributor
Author
There was a problem hiding this comment.
fork PR -> fork repo -> run test
fork PR -> main repo -> skip test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fork PRs targeting main will never be able to pass integration tests or action-in-action due to the lack of permissions that fork action/workflow get:
therefore, if you want to see the integration tests and action-in-action test passing, then a PR needs to be created in the fork repo
tests passing in the fork repo: ctcpip#25