Merged
Conversation
wesleytodd
approved these changes
Aug 8, 2025
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
Any reason not to just call this an integration test? I understand that it is not, but it feels like adding a new stage in the workflow is a bit overkill for the need here. I agree it is a good test, but just was wondering why all the rest. Not blocking and if you feel like defending it or just not wanting to undo it I am fine either way.
Contributor
Author
|
what's it's called/named isn't really important, but we don't want to bundle it with integration tests because those can't run everywhere. and the reason I didn't just add it to the existing test step is because this doesn't need to run in all node versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.