fix(watchman) #7226
Closed
fix(watchman) #7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Judging from the logs, we may need to update folly to a more recent version. The correct version (2024.09.09.00) has not yet been released on pkgx. |
|
yeah, they update every week, but have to be built in a specific order. i'll get them finished tomorrow. though watchman hasn't built for our linux targets in a few months. |
|
Gotcha. Thanks so much for maintaining these. By the way, what's the best
way to set the build-time WATCHMAN_STATE_DIR so it points to the .pkgx
directory?
…On Thu, 12 Sept 2024, 07:11 Jacob Heider, ***@***.***> wrote:
yeah, they update every week, but have to be built in a specific order.
i'll get them finished tomorrow. though watchman hasn't built for our linux
targets in a few months.
—
Reply to this email directly, view it on GitHub
<#7226 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABREPV4F2DVPF5ZNAV77UG3ZWDE35AVCNFSM6AAAAABN7UUBPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUHA4DQMBUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
that should probably be an |
jhheider
reviewed
Sep 13, 2024
| @@ -46,7 +46,7 @@ build: | |||
| WATCHMAN_STATE_DIR: "{{prefix}}/var/run/watchman" | |||
| CMAKE_ARGS: | |||
| - -DCMAKE_INSTALL_PREFIX="{{prefix}} | |||
| - -DCMAKE_PREFIX_PATH=$(echo $LIBRARY_PATH | sed 's/\/lib:/:/g; s/\/lib$//') | |||
| - -DCMAKE_PREFIX_PATH=$(echo $LIBRARY_PATH | sed 's/\/lib:/;/g; s/\/lib$//') | |||
There was a problem hiding this comment.
CMAKE_PREFIX_PATH should be fixed in pkgx 1.2.1 again. sorry for the breakage!
There was a problem hiding this comment.
Ah okay haha I was wondering what was happening...
jhheider
force-pushed
the
main
branch
2 times, most recently
from
428c792
to
aff68d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.