-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to generate notable move categories #14
Conversation
Thanks for attempting this, but theres quite a lot that needs to be fixed here.
I've pushed some changes that should start you on a better footing. Note that Antar's sets might be incorrect, if so just change the test asserts to be like to be like: expect(classifier.computeGreaterSetupMoves(GEN)).toEqual([...classifier.GREATER_SETUP_MOVES, ...additionalMovesAnatarShoildHaveAdded]); etc |
The other lists don't contain fields that I can use to filter the correct moves; I have hypothesized that I can try and filter based on the |
Great work
A clever idea, but I dont think we should rely on the descriptions as they are completely subjective |
Partially fixes #6