Skip to content

Commit

Permalink
pkp/pkp-lib#9992 Update cypress tests for side modal (#717)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jardakotesovec
jardakotesovec authored Jul 2, 2024
1 parent 275914d commit 9cf55bb
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 21 deletions.
28 changes: 14 additions & 14 deletions cypress/tests/data/60-content/CkwantesSubmission.cy.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,45 +114,45 @@ describe('Data suite: Ckwantes', function() {
cy.get('h2').contains('Contributors');
cy.get('.listPanel__item:contains("Catherine Kwantes")');
cy.get('button').contains('Add Contributor').click();
cy.get('.modal__panel:contains("Add Contributor")').find('button').contains('Save').click();
cy.get('div[role=dialog]:contains("Add Contributor")').find('button').contains('Save').click();
cy.get('#contributor-givenName-error-en').contains('This field is required.');
cy.get('#contributor-email-error').contains('This field is required.');
cy.get('#contributor-country-error').contains('This field is required.');
cy.get('.pkpFormField:contains("Given Name")').find('input[name*="givenName-en"]').type(submission.authors[0].givenName);
cy.get('.pkpFormField:contains("Family Name")').find('input[name*="familyName-en"]').type(submission.authors[0].familyName);
cy.get('.pkpFormField:contains("Country")').find('select').select(submission.authors[0].country)
cy.get('.pkpFormField:contains("Email")').find('input').type('notanemail');
cy.get('.modal__panel:contains("Add Contributor")').find('button').contains('Save').click();
cy.get('div[role=dialog]:contains("Add Contributor")').find('button').contains('Save').click();
cy.get('#contributor-email-error').contains('This is not a valid email address.');
cy.get('.pkpFormField:contains("Email")').find('input').type(submission.authors[0].email);
cy.get('.modal__panel:contains("Add Contributor")').find('button').contains('Save').click();
cy.get('div[role=dialog]:contains("Add Contributor")').find('button').contains('Save').click();
cy.wait(3000);
cy.get('button').contains('Order').click();
cy.wait(3000);
cy.get('button:contains("Decrease position of Catherine Kwantes")').click();
cy.get('button').contains('Save Order').click();
cy.get('button:contains("Preview")').click(); // Will only appear after order is saved
cy.get('.modal__panel:contains("List of Contributors")').find('tr:contains("Abbreviated")').contains('Kekkonen et al.');
cy.get('.modal__panel:contains("List of Contributors")').find('tr:contains("Publication Lists")').contains('Urho Kekkonen, Catherine Kwantes (Author)');
cy.get('.modal__panel:contains("List of Contributors")').find('tr:contains("Full")').contains('Urho Kekkonen, Catherine Kwantes (Author)');
cy.get('.modal__panel:contains("List of Contributors")').find('.modal__closeButton').click();
cy.get('div[role=dialog]:contains("List of Contributors")').find('tr:contains("Abbreviated")').contains('Kekkonen et al.');
cy.get('div[role=dialog]:contains("List of Contributors")').find('tr:contains("Publication Lists")').contains('Urho Kekkonen, Catherine Kwantes (Author)');
cy.get('div[role=dialog]:contains("List of Contributors")').find('tr:contains("Full")').contains('Urho Kekkonen, Catherine Kwantes (Author)');
cy.get('div[role=dialog]:contains("List of Contributors")').find('button:contains("Close")').click();
cy.get('.listPanel:contains("Contributors")').find('button').contains('Order').click();
cy.get('button:contains("Increase position of Catherine Kwantes")').click();
cy.get('.listPanel:contains("Contributors")').find('button').contains('Save Order').click();
cy.get('.listPanel:contains("Contributors") button:contains("Preview")').click(); // Will only appear after order is saved
cy.get('.modal__panel:contains("List of Contributors")').find('tr:contains("Abbreviated")').contains('Kwantes et al.');
cy.get('.modal__panel:contains("List of Contributors")').find('tr:contains("Publication Lists")').contains('Catherine Kwantes, Urho Kekkonen (Author)');
cy.get('.modal__panel:contains("List of Contributors")').find('tr:contains("Full")').contains('Catherine Kwantes, Urho Kekkonen (Author)');
cy.get('.modal__panel:contains("List of Contributors")').find('.modal__closeButton').click();
cy.get('div[role=dialog]:contains("List of Contributors")').find('tr:contains("Abbreviated")').contains('Kwantes et al.');
cy.get('div[role=dialog]:contains("List of Contributors")').find('tr:contains("Publication Lists")').contains('Catherine Kwantes, Urho Kekkonen (Author)');
cy.get('div[role=dialog]:contains("List of Contributors")').find('tr:contains("Full")').contains('Catherine Kwantes, Urho Kekkonen (Author)');
cy.get('div[role=dialog]:contains("List of Contributors")').find('button:contains("Close")').click();

// Delete a contributor
cy.get('.listPanel:contains("Contributors")').find('button').contains('Add Contributor').click();
cy.get('.pkpFormField:contains("Given Name")').find('input[name*="givenName-en"]').type('Fake Author Name');
cy.get('.pkpFormField:contains("Email")').find('input').type('delete@mailinator.com');
cy.get('.pkpFormField:contains("Country")').find('select').select('Barbados');
cy.get('.modal__panel:contains("Add Contributor")').find('button').contains('Save').click();
cy.get('div[role=dialog]:contains("Add Contributor")').find('button').contains('Save').click();
cy.get('.listPanel__item:contains("Fake Author Name")').find('button').contains('Delete').click();
cy.get('.modal__panel:contains("Are you sure you want to remove Fake Author Name as a contributor?")').find('button').contains('Delete Contributor').click();
cy.get('div[role=dialog]:contains("Are you sure you want to remove Fake Author Name as a contributor?")').find('button').contains('Delete Contributor').click();
cy.get('.listPanel__item:contains("Fake Author Name")').should('not.exist');

cy.get('.submissionWizard__footer button').contains('Continue').click();
Expand Down Expand Up @@ -215,7 +215,7 @@ describe('Data suite: Ckwantes', function() {
cy.contains('Make a Submission: Review');
cy.get('button:contains("Submit")').click();
const message = 'Are you sure you want to submit ' + submission.title + ' to ' + Cypress.env('contextTitles').en + '? Once you submit, a moderator will review the preprint before posting it online.';
cy.get('.modal__panel:contains("' + message + '")').find('button').contains('Submit').click();
cy.get('div[role=dialog]:contains("' + message + '")').find('button').contains('Submit').click();
cy.contains('Submission complete');
cy.get('a').contains('Create a new submission');
cy.get('a').contains('Return to your dashboard');
Expand Down
2 changes: 1 addition & 1 deletion cypress/tests/data/60-content/DphillipsSubmission.cy.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('Data suite: Dphillips', function() {
cy.get('#publication-button').click();
cy.get('button').contains('Unpost').click();
cy.contains('Are you sure you don\'t want this to be posted?');
cy.get('.modal__panel button').contains('Unpost').click();
cy.get('div[role=dialog] button').contains('Unpost').click();
cy.wait(1000);
cy.visit('/index.php/publicknowledge/preprints');
cy.contains('Signalling Theory Dividends').should('not.exist');
Expand Down
12 changes: 6 additions & 6 deletions cypress/tests/integration/Doi.cy.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ describe('DOI tests', function() {
});

it('Check Assignment for multi-version submissions', function() {
const modalSelector = '.modal';
const modalSelector = 'div[role="dialog"]';
const articleTitle = 'Computer Skill Requirements for New and Existing Teachers: Implications for Policy and Practice';

loginAndGoToDoiPage();
Expand Down Expand Up @@ -283,7 +283,7 @@ describe('DOI tests', function() {
});

it('Check DOI versioning behaviour in workflow', function() {
const modalSelector = '.modal';
const modalSelector = 'div[role="dialog"]';
const articleTitle = 'The Facets Of Job Satisfaction: A Nine-Nation Comparative Study Of Construct Equivalence'

loginAndGoToDoiPage();
Expand All @@ -308,7 +308,7 @@ describe('DOI tests', function() {

cy.get('button#publication-button').click();
cy.get('button:contains("Unpost")').click();
cy.get('.modal button:contains("Unpost")').click();
cy.get('div[role="dialog"] button:contains("Unpost")').click();

cy.get('button:contains("Unpost")').should('not.exist');

Expand Down Expand Up @@ -353,8 +353,8 @@ describe('DOI tests', function() {
cy.get('button#publication-button').click();

cy.get('button:contains("Create New Version")').click();
cy.get('.modal').contains('Create New Version');
cy.get('.modal button:contains("Yes")').click();
cy.get('div[role="dialog"]').contains('Create New Version');
cy.get('div[role="dialog"] button:contains("Yes")').click();

cy.get('button:contains("Post")').click();
cy.get('div.pkpWorkflow__publishModal button:contains("Post")').click();
Expand Down Expand Up @@ -490,7 +490,7 @@ describe('DOI tests', function() {

// We have to unpost it first
cy.get('button:contains("Unpost")').click();
cy.get('.modal button:contains("Unpost")').click();
cy.get('div[role="dialog"] button:contains("Unpost")').click();
cy.get('button:contains("Post")').should('not.exist');

cy.get('button:contains("Post")').click();
Expand Down

0 comments on commit 9cf55bb

Please sign in to comment.