Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10131 cleanup for Orcid implementation cleanup #10370

Merged
merged 1 commit into from
Sep 11, 2024
Merged

pkp/pkp-lib#10131 cleanup for Orcid implementation cleanup #10370

merged 1 commit into from
Sep 11, 2024

Conversation

taslangraham
Copy link
Contributor

@taslangraham taslangraham commented Sep 5, 2024 •
edited
Loading

For #10131

@taslangraham taslangraham force-pushed the i10131-main branch 2 times, most recently from 59a8c0c to 420c498 Compare September 5, 2024 22:15
@taslangraham taslangraham marked this pull request as ready for review September 5, 2024 23:35
@taslangraham taslangraham mentioned this pull request Sep 6, 2024
Closed
2 tasks
ewhanson
ewhanson requested changes Sep 10, 2024
View reviewed changes
api/v1/orcid/OrcidController.php Outdated Show resolved Hide resolved
api/v1/orcid/OrcidController.php Outdated Show resolved Hide resolved
@taslangraham
Copy link
Contributor Author

@ewhanson thanks for the review. I've made the suggested changes

@ewhanson ewhanson merged commit a38102f into pkp:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewhanson ewhanson ewhanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taslangraham @ewhanson