pkp/pkp-lib#12347 Proper log history for submission file revision upload#12352
Open
touhidurabir wants to merge 4 commits intopkp:mainfrom
Open
pkp/pkp-lib#12347 Proper log history for submission file revision upload#12352touhidurabir wants to merge 4 commits intopkp:mainfrom
touhidurabir wants to merge 4 commits intopkp:mainfrom
Conversation
touhidurabir
force-pushed
the
i12347_main
branch
from
12f63ff to
5d4423b
Compare
1 task
touhidurabir
force-pushed
the
i12347_main
branch
2 times, most recently
from
03525cb to
fc54797
Compare
touhidurabir
force-pushed
the
i12347_main
branch
from
3daa2b7 to
d86d17b
Compare
touhidurabir
commented
Feb 24, 2026
Comment on lines
391
to
+402
| @@ -396,6 +399,7 @@ public function edit( | |||
| 'dateLogged' => Core::getCurrentDate(), | |||
| ] | |||
| )); | |||
| Repo::eventLog()->add($submissionLogEntry); | |||
Member
Author
There was a problem hiding this comment.
it seems we have the log history for submission created here but never inserted the record in DB.
touhidurabir
force-pushed
the
i12347_main
branch
from
d86d17b to
fbf0205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #12347 .